Update event-loop-timers-and-nexttick.md#8611
Open
slavamuravey wants to merge 1 commit intonodejs:mainfrom
Open
Update event-loop-timers-and-nexttick.md#8611slavamuravey wants to merge 1 commit intonodejs:mainfrom
slavamuravey wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Member
|
Bump @nodejs/timers |
avivkeller
approved these changes
Mar 12, 2026
aymen94
approved these changes
Mar 12, 2026
AugustinMauroy
approved these changes
Mar 13, 2026
Member
|
@slavamuravey please rebase |
Signed-off-by: Viacheslav Muravyev <slavamuravey@mail.ru>
Author
|
@avivkeller Rebased |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8611 +/- ##
==========================================
+ Coverage 75.27% 75.28% +0.01%
==========================================
Files 105 105
Lines 9242 9242
Branches 326 326
==========================================
+ Hits 6957 6958 +1
+ Misses 2283 2282 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Member
|
@slavamuravey Quality check failed. Could you format the files with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I investigated libuv
uv_runfunction and libuv Design overview section and I propose to correct Node.js documentation related with event loop phases order.It is a common misconception to think that the timer phase is the first one. Actually, it is the last one within event loop iteration.